coreui / coreui-pro / 32542339457

93%

main: 94%

push

github

refactor(Dialog, Drawer, Menu, Popup): read one overlay easing from :root (#838)

The same `cubic-bezier(.22, 1, .36, 1)` was written out in four component files.
Retiming the overlays meant finding all four and keeping them in step by hand,
and nothing failed if one drifted.

`--cui-transition-timing-overlay` is declared on `:root` and the four components
read it, so one declaration restyles all of them at runtime. Verified in
Chromium: with the token overridden to `linear`, `transition-timing-function`
follows on dialog, drawer, menu and popup; left alone, all four still resolve to
`cubic-bezier(0.22, 1, 0.36, 1)`, unchanged. Each component keeps its own
`--cui-{component}-transition-timing`, so one overlay can still opt out.

`coreui-reboot.min.css` goes to 5.02 kB against a 5 kB ceiling it was already
sitting on exactly. The extra token is one `:root` declaration; budget raised to
5.25 kB.

4537 of 5095 branches covered (89.05%)

Branch coverage included in aggregate %.

8661 of 9055 relevant lines covered (95.65%)

399.93 hits per line