archetech / archon / 32519449960

87%

push

github

fix(gatekeeper): skip the universal resolver for our own DID method (#899)

A locally-unresolvable DID was sent to the universal resolver regardless
of its method. For DIDs of the gatekeeper's own method that is pointless
work: a universal resolver has no driver for it, so the request burns the
full fallback timeout before failing, and only then is the confirm
fallback -- another Archon gatekeeper, which can actually resolve it --
tried.

Observed on a live node as ~2,868 log lines/hour of "Universal resolver
fallback failed", each costing a 2.5s stall, driven by clients polling
DIDs this node does not host. Two unrelated clients produced it days
apart, so it is a property of the dispatch order rather than one
misbehaving peer.

The guard compares against the configured didPrefix rather than a
hardcoded "did:cid", and falls open: with no prefix configured nothing
counts as our own method and behaviour is unchanged.

Applied to both gatekeeper flavors per the parity contract.

Note for reviewers: this changes behaviour for anyone whose
ARCHON_GATEKEEPER_FALLBACK_URL points at a resolver that *does* have a
driver for this method -- such DIDs now resolve via the confirm fallback
instead. The two existing fallback tests used did:cid purely as a sample
DID; they now use did:web/did:ethr, which is what that path is for, plus
new cases pinning the skip and confirming it is not too broad.

Co-authored-by: flaxscrip <flaxscrip@archon.social>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3790 of 4272 branches covered (88.72%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

8437 of 8739 relevant lines covered (96.54%)

686.21 hits per line