archetech / archon / 32518558576

87%

push

github

refactor(wallet): Share the wallet UI (closes #894) (#912)

* refactor(wallet): Share seven presentational components

Next slice of #894, and the first that is mostly moving rather than
untangling: the contexts landed last time, so components that only needed
those can go across as they are.

Moved: DmailDialog, CopyDID, CopyResolveDID, DisplayDID, MnemonicModal,
DmailSearchModal, AuthDetailsModal.

**Each base was chosen per file, not by rule.** react-wallet turned out not to
be uniformly the more modern copy: the extension's AuthDetailsModal uses the
current MUI slotProps API where react-wallet still used the deprecated
InputProps, and it has a "Show password" tooltip react-wallet lacks, so that
one takes the extension's version. DisplayDID, MnemonicModal and
DmailSearchModal take react-wallet's, so the extension gains the dialog and
layout styling from #893 -- a visible change to that wallet, which is the
direction #894 wants but is worth knowing before it merges. DmailDialog was
already identical.

**ViewerNavigation, a new seam.** "Open this DID in the viewer" is something
both wallets do and neither does the same way -- react-wallet switches its own
tab through UIContext, the extension opens a chrome tab -- and those UIContexts
are deliberately unshared. Passing the action down as a prop was the obvious
alternative and a bad one: CopyResolveDID renders at eighteen sites and
DisplayDID at ten, most inside the large diverged tabs this refactor has not
reached, so prop-drilling would mean editing exactly the files that are hardest
to review. It is a one-function context each app supplies once instead.

CopyDID needed no seam at all: handleCopyDID is already on the shared
useWalletData hook, so it reads from there rather than from either UIContext.

Not in this slice: PassphraseModal, WarningModal, TextInputModal and
PollResultsModal all read useThemeContext for isTabletUp, which only one wallet
has; they need that injected. BrowserHeader and Prope... (continued)

3775 of 4256 branches covered (88.7%)

Branch coverage included in aggregate %.

0 of 5 new or added lines in 1 file covered. (0.0%)

8435 of 8737 relevant lines covered (96.54%)

686.33 hits per line