archetech / archon / 32521171895

87%

push

github

test(gatekeeper): Cover the universal-resolver skip in Rust, and say why it falls open (#918)

#899 fixed both flavors but tested only TypeScript, so a Rust refactor could
drop the `!is_own_method` clause and leave every check green. That is the shape
of #799, where a TS-only fix shipped for a bug both ports had.

tests/universal_resolver_fallback.rs spawns the real binary with
ARCHON_GATEKEEPER_FALLBACK_URL pointed at a TCP listener that counts requests
and answers immediately, so nothing waits on the fallback timeout. Five cases:
an unresolvable DID of this node's own method never reaches the resolver; a
foreign method still does; a custom prefix is honoured (its own method skipped,
did:cid delegated as foreign); a locally-known DID never reaches it; and an
empty prefix falls back to the default.

That last one corrected an assumption. I wrote it expecting the documented
fall-open, and it failed: `env_var_or_default` filters blank values, so an
explicitly empty ARCHON_GATEKEEPER_DID_PREFIX yields "did:cid" and the skip
still applies. TypeScript does the same via `|| 'did:cid'`. So the fall-open
branch is real but unreachable through configuration -- defensive only, in both
flavors -- and no environment can accidentally disable the skip. The test now
pins that rather than the behaviour I assumed.

The Rust check is also explicit now. It relied on `format!("{}:", "")` yielding
":" (which no DID starts with) to fall open, which is correct by accident of
string shape; it says `!prefix.is_empty()` like the TypeScript side.

Verified by mutation: removing `!is_own_method` fails three of the five.

No cargo fmt churn -- the crate has 91 pre-existing fmt diffs on main
(AGENTS.md). Only the new file is formatted; rustfmt reformatting
tests/common/mod.rs through `mod common;` was reverted.

Refs #899

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3791 of 4272 branches covered (88.74%)

Branch coverage included in aggregate %.

8437 of 8739 relevant lines covered (96.54%)

686.21 hits per line