radio-t / stream-recorder / 32317712585

76%

Build Type

push

github

Committed by web-flow

Commit Message

Fix the VBR header before writing metadata (#30)

The ffmpeg remux rebuilds the ID3 tag from the stream metadata it
understands. CHAP, CTOC and the text frames survive, but the WXXX
sub-frame carrying each chapter's article link does not, so every
recording processed with ffmpeg present lost the links the README
promises.

Run the VBR fix first and inject the metadata afterwards. ffmpeg pads
the tag it writes, and ID3v2 puts padding after the last frame, so
InjectFrames now walks the existing frames and drops the padding rather
than appending behind it where a conformant parser stops reading.

Adds an ffmpeg-gated regression test running both steps over a real MP3
and asserting the final file keeps CHAP, CTOC, WXXX, the URL, the
Xing/Info header and a readable TLEN.

Co-authored-by: Umputun <umputun@gmail.com>

Coverage Stats

36 of 44 new or added lines in 2 files covered. (81.82%)

1 existing line in 1 file now uncovered.

994 of 1319 relevant lines covered (75.36%)

8.22 hits per line