rero / rero-ils / 31463948849

92%

staging: 92%

Build Type

push

github

Committed by PascalRepond

Commit Message

fix(permissions): repair wiki edition permission

The wiki edition views crashed with an AttributeError for any logged
user: flask-security's `roles_required` reads `current_app.security`,
an attribute flask-security-invenio never sets, as it registers its
state in `app.extensions["security"]` only.

* Replace the nested `login_required`/`roles_required` decorators by
  an explicit authentication and role check.
* Grant the edition to the `admin` role as well, to match
  `wiki_edit_ui_permission`, which drives the edit buttons display.
* Add a test covering the anonymous, unauthorised and editor cases.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

131 existing lines in 12 files now uncovered.

24273 of 26593 relevant lines covered (91.28%)

0.91 hits per line