rero / rero-ils

91%

LAST BUILD ON BRANCH staging

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• angular-update
• bib-latest
• bib-memovs
• bib-test
• bib-v.1.25.1
• bib-v1.25.0
• bib-v1.25.2
• bib-v1.26.0
• dependabot/npm_and_yarn/tests/e2e/cypress/lodash-4.17.23
• dependabot/npm_and_yarn/tests/e2e/cypress/lodash-4.18.1
• dependabot/npm_and_yarn/tests/e2e/cypress/minimatch-3.1.5
• dependabot/npm_and_yarn/tests/e2e/cypress/multi-58fc06ecb0
• dependabot/npm_and_yarn/tests/e2e/cypress/tmp-0.2.4
• dependabot/npm_and_yarn/tests/e2e/cypress/tmp-0.2.6
• dependabot/uv/lxml-html-clean-0.4.4
• dependabot/uv/nbconvert-7.17.1
• dependabot/uv/pip-26.0
• dependabot/uv/urllib3-2.6.3
• dependabot/uv/uv-8177a8837a
• dependabot/uv/werkzeug-3.1.6
• goa-fix-thumbnail-size
• goa-homepage-editor
• goa-homepage-mappings
• goa-update-dependencies
• goa-user-editor
• ils-dev
• ils-test
• maj-acq-add-remove-message
• maj-can-request-codes
• maj-fix-3733
• maj-fix-concurrency
• maj-fix-locations-aggs
• maj-fix-overdue-api-permissions
• maj-fix-sip2-translations
• maj-test-lib-allow-receipt-update
• maj-uv
• master
• next-version
• rep-anonyme
• rep-anonymise
• rep-assign-pr
• rep-auto-renew-fixtures
• rep-babel
• rep-call-numbers
• rep-canton
• rep-claims
• rep-claude
• rep-clean-docs
• rep-coll
• rep-coll-validation
• rep-collections
• rep-copyright-headers
• rep-date-range-offset
• rep-deps
• rep-doc-notes
• rep-docs
• rep-dropdowns
• rep-email
• rep-extend-open
• rep-fa7
• rep-fix-css
• rep-fix-encoding
• rep-fix-es-memory
• rep-fix-homepage
• rep-fix-inactive-orders
• rep-fix-loc-note
• rep-fix-owning-distrib
• rep-fix-patron-oplog
• rep-fix-release
• rep-fix-static
• rep-fixtures
• rep-frebooks
• rep-genreform
• rep-genreforms
• rep-header
• rep-index-request-limits
• rep-invenio-update
• rep-inventory
• rep-irregular
• rep-item-type-distrib
• rep-item-type-links
• rep-lib-notif
• rep-loc-note
• rep-location-labels
• rep-lofi-permissions
• rep-nb
• rep-nginx
• rep-not-expired
• rep-notif-counter
• rep-oplog-request-date
• rep-order-cache
• rep-org-json
• rep-patron
• rep-patron-delete
• rep-patron-role
• rep-patron_setting
• rep-prefixes
• rep-redis
• rep-release
• rep-release-workflow
• rep-reminders
• rep-request-limits
• rep-ris
• rep-ruff
• rep-scan-help
• rep-sort-date
• rep-sru
• rep-stat-distrib
• rep-swisscovery
• rep-temporary-item-type-remove
• rep-test-fix
• rep-translate
• rep-translates
• rep-ugent
• rep-vs-link
• staging
• translations
• v1.25.0
• v1.25.1
• v1.25.2
• v1.26.0
• v1.27.0
• v1.27.1
• v1.28.0
• weblate-rero_plus-rero-ils
• wep-#4010-import_from_the_web
• wep-acq-amounts-as-cents
• wep-add-operationlogs-mapping
• wep-allow-delete-order-lines
• wep-better-acquisitions
• wep-better-delete-holding
• wep-better-tests
• wep-custom-css
• wep-delete_item-with-collection
• wep-dependencies
• wep-dependencies-setuptools
• wep-disable-scheduler-tasks-dev
• wep-es-search
• wep-fix-create_next_late_expected_issues
• wep-fix-datetimeutc
• wep-fix-facets
• wep-fix-fixtures
• wep-fix-ill_request
• wep-fix-import-loc
• wep-fix-imports
• wep-fix-loc-import
• wep-fix-poe
• wep-fix-process_late_issues
• wep-fix-reindex_document_items
• wep-fix-rollover
• wep-fix-scheduler
• wep-fix-subject-imports
• wep-fix-thumbnails
• wep-fix-timezone
• wep-harvesting-audiovisual-archives
• wep-import-dnb-slsp-mef-link
• wep-import-scott-polar
• wep-new-version-scheduler
• wep-opensearch
• wep-operation_log-item-scan
• wep-provisionactivity-date-9999
• wep-rebbitmq-redis
• wep-remove-cypress
• wep-remove-types
• wep-remove-webpack-project
• wep-sru
• wep-tests-import-transformation
• wep-thumbnails
• zub-available-languages
• zub-collection-search-organisation-fix
• zub-holdings-analyzed-field
• zub-holdings-items
• zub-ill-serializer-fix
• zub-number-step
• zub-page-title
• zub-record-reason-permission-improvement
• zub-sticky-zindex-fix
• zub-translate-fix
• zub-user-datepicker-config

Build # 28779637764

Build Type

push

github

Committed by PascalRepond

Commit Message

fix(acquisition): allow cancelling the last non-received order line

Cancelling the last non-received line of a partially received order makes
the order fully received. The REST PUT calls the record's overridden
update() (which commits and reindexes), then invenio commits again and
re-runs extended_validation, which then saw the order as RECEIVED and
rejected it with "wrong status" -- even though the cancellation had
already persisted, leaving the line cancelled but surfacing an error.

Accept RECEIVED in extended_validation when the line is being cancelled:
a cancellation is always valid, and the update permission (evaluated once
on the prior status) remains the real gate. Also fix and translate the validation
docstring (it omitted the order-status check and claimed a False return)
and reword the message to "save" instead of "create" so it no longer
implies a creation on updates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

24249 of 26551 relevant lines covered (91.33%)

0.91 hits per line