wol-soft / php-json-schema-model-generator / 31428786369

99%

master: 99%

Build Type

Pull #185

github

Committed by wol-soft

Commit Message

Address PR review comments on the PropertyMerger consolidation

- Derive the object structural-keyword list in PropertyFactory from the
  draft's own registered validators (Draft::getKeywordsForType()) instead
  of a hardcoded, partly-aspirational constant, so it stays in sync as
  drafts add real keyword support.
- Keep GeneratorConfiguration's public draft API unchanged (getDraft/
  setDraft/getBuiltDraft) while moving the built-draft cache into a
  private DraftResolver, since PostProcessor's public extension contract
  only ever provides GeneratorConfiguration, not SchemaProcessor.
- Document (with a regression test) why resolveReference()'s cache key
  must include isArrayItem unconditionally: gating it behind implicit-
  null would let an array-item and a plain optional-property usage of
  the same $ref collide, corrupting the optional property's nullability.
- Merge the two type-narrowing tests in RefSiblingsPropertyLevelTest into
  one, with full exception-message assertions and a getter type-hint
  check.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #185: Draft-aware $ref+sibling handling (Draft 2019-09+)

Coverage Stats

427 of 430 new or added lines in 18 files covered. (99.3%)

2 existing lines in 1 file now uncovered.

7561 of 7652 relevant lines covered (98.81%)

579.26 hits per line