wol-soft / php-json-schema-model-generator
99%
master: 99%

LAST BUILD BRANCH: unevaluated-properties
DEFAULT BRANCH: master
Repo Added
Files 199
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH unevaluated-properties
branch: SELECT
CHANGE BRANCH
x

coverage: 98.906% (+0.03%) from 98.88%
31972611204

Pull #157

github

wol-soft 
Close remaining Phase 3 coverage gaps for accessor mutation paths

Cross-referenced a fresh --coverage-clover run against the original
gap analysis (57 uncovered lines) rather than trusting behavioral
verification alone. Closes two of the four remaining lines:

- UnevaluatedItemsValidatorFactory's dead-code classifier falls
  through to "not dead code" for items: null (not a valid items
  value) rather than misclassifying it as one of the three recognised
  dead-code shapes.

Also documents a genuine, previously-undiscovered bug found while
tracing the other two lines: a composition branch's own
unevaluatedProperties never sees properties the enclosing schema (or
a sibling branch) declares -- only the reverse direction (branch
claims propagating up to an outer unevaluatedProperties) was ever
built. `{properties: {name}, allOf: [{unevaluatedProperties: false}]}`
wrongly rejects {name: "Alice"} even though name is declared and
validated by the enclosing schema. Root cause and revisit trigger are
in implementation-plan.md item 20; surfaced here via markTestIncomplete
since the fix touches how a branch's nested class computes its
evaluated set, not a single call site.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pull Request #157: Unevaluated properties

1087 of 1097 new or added lines in 43 files covered. (99.09%)

8952 of 9051 relevant lines covered (98.91%)

575.6 hits per line

Relevant lines Covered
9051 RELEVANT LINES 8952 COVERED LINES
575.6 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
31972611204 unevaluated-properties Close remaining Phase 3 coverage gaps for accessor mutation paths Cross-referenced a fresh --coverage-clover run against the original gap analysis (57 uncovered lines) rather than trusting behavioral verification alone. Closes two of the four rem... Pull #157 wol-soft github
98.91
31808505301 unevaluated-properties Close remaining Phase 3 coverage gaps for accessor mutation paths Adds regression coverage for harvestCompositionPropertyNames()'s if/then/else recursion, found by cross-referencing a fresh coverage report against the earlier gap analysis: allOf/... Pull #157 wol-soft github
98.9
31713051742 unevaluated-properties Add regression test for composition dropped inside array branches Recovers testCompositionNestedInsideArrayBranchIsNotSilentlyDropped and its fixture, which had only ever been git-stashed before the master merge and never actually landed on the b... Pull #157 wol-soft github
98.54
31641488273 master Merge pull request #166 from wol-soft/claude/mr-74-review-adoption-3p8hdm Fix crashes and silent misvalidation in object-implied compositions, reject non-representable ones push web-flow github
98.88
31640503194 claude/mr-74-review-adoption-3p8hdm Fix defects found while reviewing the object-shape work Four crashes and false rejections, each verified against master to separate regressions from pre-existing behaviour. An allOf branch whose declared type is a LIST containing "object" was re... Pull #166 wol-soft github
98.88
31431102822 claude/mr-74-review-adoption-3p8hdm Merge master: adopt draft-aware $ref sibling handling Master replaced JsonSchema's allOf rewrite hack for {$ref, siblings} with a draft-aware producer model, and moved the reference resolution out of PropertyFactory into RefResolver. Three things... Pull #166 claude github
98.9
31429899973 master Merge pull request #185 from wol-soft/feature/ref-sibling-draft-aware Draft-aware $ref+sibling handling (Draft 2019-09+) push web-flow github
98.81
31429310725 feature/ref-sibling-draft-aware Use the test helper's getReturnTypeNames() instead of raw reflection AbstractPHPModelGeneratorTestCase already provides getReturnTypeNames() for asserting nullable/union type hints; use it instead of manually building a ReflectionClass/Reflection... Pull #185 wol-soft github
98.81
31428786369 feature/ref-sibling-draft-aware Address PR review comments on the PropertyMerger consolidation - Derive the object structural-keyword list in PropertyFactory from the draft's own registered validators (Draft::getKeywordsForType()) instead of a hardcoded, partly-aspirational... Pull #185 wol-soft github
98.81
31333517295 claude/docs-schema-consistency-kq0qwe Merge 5901be844 into f647e32c0 Pull #188 web-flow github
98.76
See All Builds (837)