wol-soft / php-json-schema-model-generator / 31146836008

99%

push

github

Fix AutoDetectionDraft falling back to Draft 07 for every property-level schema (#187)

* Fix AutoDetectionDraft falling back to Draft 07 for every property-level schema

$schema is a document-root-only keyword, but AutoDetectionDraft re-derived it
from whichever JsonSchema node it was handed. Every navigated subschema
(properties, $ref targets, composition branches, ...) never carries $schema,
so draft detection always fell back to Draft 07 outside the literal document
root, silently dropping Draft 2019-09-only behavior like minContains/maxContains.

JsonSchema now tracks the $schema URI in effect for each node: the node's own
$schema if declared, otherwise inherited from the nearest ancestor. navigate()
and withJson() re-derive it after cloning, so the inherited value survives
down the whole tree while a local override on an embedded schema resource
(a subschema with its own $id, per the JSON Schema core spec) still takes
effect for its own descendants.

Fixes #186

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019nLMK2e753YDaXexRr1Z1B

* Fix regression test assertions for allOf-wrapped composition errors

An allOf branch failure surfaces as a generic AllOfException in fail-fast
mode, discarding the underlying MinContainsException/MaxContainsException;
the specific error is only preserved in the branch's error collection when
collecting errors. Switch the AutoDetectionDraft regression test to collect
errors and unwrap the branch-specific exception, matching the existing
RequiredPropertyTest pattern for allOf branch assertions.

Verified against master: the full suite (2971 tests) passes, and the new
test fails as expected when the fix in JsonSchema/AutoDetectionDraft is
reverted, confirming it actually exercises the regression.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019nLMK2e753YDaXexRr1Z1B

* Ignore .claude/ working notes direct... (continued)

8 of 8 new or added lines in 2 files covered. (100.0%)

7250 of 7341 relevant lines covered (98.76%)

1664.24 hits per line