lsm / HyperNeo / 31404737526

79%

push

github

docs(design): address Codex review on in-app browser design (#2436)

* docs(design): address Codex review on in-app browser design

Incorporates all 7 Codex review comments on the in-app browser design:

- P1 shared-browser bridge: the pane must depict the browser the agent actually
  drives. Existing skills (playwright / playwright-interactive / chrome-devtools-mcp)
  own isolated browsers and don't expose Page/CDP to the daemon, so the service
  must own the single shared Chromium (replace) or attach to a tool-exposed CDP
  endpoint (bridge). Added as the central prerequisite.
- P1 backpressure: screencast loop now keeps at most one frame in flight and
  acks CDP only after the client reports consumption (was acking on enqueue).
- P2 per-session frame channels: browser.frame:<sessionId>; panes join a
  specific session channel so one session cannot render another's authenticated
  pixels.
- P2 tab/page lifecycle: per-page CDP sessions; atomic switch of render + input
  on activation change.
- P2 keyboard event protocol: keydown/keyup/press/text/composition instead of
  only page.keyboard.type(text).
- P2 pointer mapping: derived from decoded frame dims + screencastFrame metadata
  (pageScaleFactor, scroll offsets) and letterbox offset, not a naive ratio.
- P2 Chromium packaging: Playwright is a dev-only dependency today, so a release
  build needs an explicit bundle or first-run-install strategy (not lazy download).

Doc only; still exploratory, not implemented.

* docs(design): address Codex round-2 review (transport/lifetime/dep accuracy)

Corrects API-level inaccuracies the round-2 Codex review caught against the
actual source:

- MessageHub: method is a plain string; session scoping goes in the channel
  option (session:<id>), never in the method. browser.frame:<sessionId> as a
  method is invalid. Events are fire-and-forget — there is no onConsumed — so
  backpressure now uses an explicit browser.frameAck {frameId} request with
  disconnect/tim... (continued)

20386 of 57687 branches covered (35.34%)

Branch coverage included in aggregate %.

30290 of 68191 relevant lines covered (44.42%)

281.16 hits per line