lsm / HyperNeo / 31416549690

79%

Build Type

push

github

Committed by web-flow

Commit Message

feat(space): extend EventInterest with topicFrom for dynamic topic resolution (#2437)

* feat(space): extend EventInterest with topicFrom for dynamic topic resolution

Add an optional `topicFrom` to EventInterest as an extensible alternative to a
static `topic` glob. A `topicFrom: { source: 'primaryLink', pattern }` interest
carries placeholders ({owner}/{repo}/{number}/{host}) resolved from a workflow
run's primary PR link at subscription time, so a static workflow can subscribe
to "this run's own PR" without baking a PR number into the template.

PR 1 of the external-event subscription refactor (inert): ships the type, zod
schema, validation, and a pure resolveTopicFromInterest helper with unit tests.
Nothing consumes topicFrom yet — the runtime registration path keeps treating
only static `topic` interests as live, so existing workflows are unchanged.

- EventInterest.topic is now optional; exactly-one-of topic/topicFrom is
  enforced by both the zod schema and validateEventInterests.
- Unify WorkflowNodeAgent.eventInterests onto EventInterest[] (it was a
  duplicate inline type) so topicFrom flows through create/update validation.
- resolveTopicFromInterest fills placeholders via parsePrUrl and returns null
  for no-topicFrom / unknown source / unparseable URL.
- SpaceRuntime.registerRunInterests skips topicFrom interests until resolution
  is wired in PR 2/3, keeping them out of the topic trie.

Refs #903.

* address review: single switch point, zod pattern alignment, JSDoc honesty, glob cross-checks

- resolveTopicFromInterest branches on KNOWN_TOPIC_FROM_SOURCES.has(source) and
  dispatches per-source via switch, making the set the single switch point (a
  source admitted by the validator always reaches a resolver branch). Drops the
  redundant loose cast + typeof guard.
- Align zod topicFrom.pattern to .trim().min(1) to match the manager validator,
  so whitespace-only patterns fail at import rather than only at createWorkflow.
- Soften EventI... (continued)

Coverage Stats

20395 of 57740 branches covered (35.32%)

Branch coverage included in aggregate %.

5 of 62 new or added lines in 4 files covered. (8.06%)

6 existing lines in 5 files now uncovered.

30295 of 68244 relevant lines covered (44.39%)

281.22 hits per line