bleedingdeacons / register / 31263285920
50%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 22
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.768%. Remained the same
31263285920

push

github

web-flow 
chore: remove genuinely dead code, and stop misreading the rest (#26)

Clears S1144 and S125 (184 -> 160 warnings on the Android head, 0 errors). Two
thirds of the sites were real; the rest were analyser false positives, and acting
on those as originally planned would have broken the app.

Deleted, genuinely unused:

  * 8 `private static readonly ILogger Logger` fields that no method referenced
    (CacheService and 7 viewmodels).
  * 6 blocks of commented-out code: an abandoned AddDbContext registration and a
    superseded singleton DbContextFactory in MauiProgram, a dead
    ResolveSecureSocketOptions and a commented-out
    ServerCertificateValidationCallback in EmailService, and two stale
    _resolvedAppName/_resolvedEnvironment statics.

NOT deleted — S1144 false positives, suppressed with justification instead:

  BuildSmtpConfiguration, ReadJsonProperty, ReadJsonPropertyAsync, GetSecretSync
  and GetSecretAsync in ConfigurationService are each called only from the #else
  branch of `#if USE_DEV_CREDENTIALS`. A local build defaults to
  UseDevCredentials=true, so the compiler never sees those call sites and the
  analyser concludes the methods are dead. They are not: they are the entire
  production credential path. Deleting them would have broken every release build
  while leaving dev builds green.

  Confirmed by building with -p:UseDevCredentials=false (what CI and
  build-register.ps1 use): 13 S1144 warnings become 8, and the 5 that vanish are
  exactly these. Each now carries a [SuppressMessage] naming the reason.

NOT deleted — S125 false positives, reworded instead:

  5 of the 11 S125 sites were ordinary prose comments that happen to end in a
  semicolon, which S125's parser reads as a statement:

      // Connectivity events fire on a background thread on Android;
      // ContentSize.Height can be 0 transiently during layout passes;

  These document real subtleties and deleting them would lose that. Changed the
  offending semicol... (continued)

680 of 741 relevant lines covered (91.77%)

5.28 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31263285920.1 22
91.77
GitHub Action Run
Source Files on build 31263285920