coreui / coreui-pro / 31191199006

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(Collapse)!: drop the toggle option (#710)

The `toggle` option made the constructor change the state that the markup
declares. That surprised people, so almost every caller passed
`toggle: false` — including our own data API, our accordion wiring and the
jQuery bridge.

The constructor now always keeps the declared state. Add `.show` to start
open, and call `show()`, `hide()` or `toggle()` to change it.

BREAKING CHANGE: `toggle` is no longer a Collapse option. Replace
`new Collapse(el, { toggle: false })` with `new Collapse(el)`, and a caller
that relied on the constructor toggling with `new Collapse(el).toggle()`.
`data-coreui-toggle` on a trigger is unrelated and unchanged.

Ported from twbs/bootstrap#42799.

Coverage Stats

4267 of 4819 branches covered (88.55%)

Branch coverage included in aggregate %.

3 of 0 new or added lines in 0 files covered. (NaN%)

2 existing lines in 1 file now uncovered.

8281 of 8675 relevant lines covered (95.46%)

363.48 hits per line