coreui / coreui-pro / 31191050586

93%

main: 94%

push

github

feat(JavaScript): return a promise from the lifecycle methods (#708)

`show()`, `hide()`, `toggle()` and `close()` returned before the transition
ended, so a caller had to listen for a `shown.coreui.*` or `hidden.coreui.*`
event to continue. `_queueCallback` now returns a promise and each component
awaits it, so a caller can `await` the method instead.

The promise always settles, so a no-op call — already open, a prevented
`show.coreui.*`, an instance disposed mid-transition — cannot strand the
caller. That last case also needed the completion callback to be skipped once
the instance is gone, which `_queueCallback` now does.

Covered by Collapse, Menu, Modal, Offcanvas, Popover, Sidebar and Tooltip
(`show`/`hide`/`toggle`), Toast (`show`/`hide`), Tab (`show`) and Alert
(`close`). Carousel keeps its own cue-based API. The event path is unchanged.

Ported from twbs/bootstrap#42802, adapted to the components this tree has.

4272 of 4825 branches covered (88.54%)

Branch coverage included in aggregate %.

53 of 53 new or added lines in 9 files covered. (100.0%)

8285 of 8681 relevant lines covered (95.44%)

363.52 hits per line