kobotoolbox / kpi / 31163039031

82%

master: 76%

push

github

fix(bulkProcessing): hide transcript language from bulk translation modal DEV-2622 (#7403)

### 📣 Summary

The language a transcript is already in is no longer offered when
creating a translation, so you can't accidentally translate English into
English and end up with a blank column you can't get rid of.

### 💭 Notes

Translating a transcript into its own language created an empty column
in the data table that couldn't be removed, and nothing appeared under
Translations. Fix is to keep that language out of the dropdown in the
first place.

Changes here:

- `jsapp/js/components/processing/common/utils.ts`
- `getTranslationSourceLanguages()` — new. Returns the language codes a
new translation must not target for a given question. Picks the source
transcript the way the back end does in
`RequiresTranscriptionMixin.attach_action_dependency`: newest
`_dateAccepted`, skipping versions never accepted and ones whose text is
gone. Note this is deliberately *not*
`getLatestTranscriptVersionItem()`, which sorts by creation date — when
versions are accepted out of order the two pick different versions, and
following the wrong one would hide the wrong language and let the bug
straight back in. Both helpers stay, doc comments warn against swapping
them.
- `getBlockedTargetLanguages()` — new, and the reason this is a list
rather than one code. The back end translates from `locale` when it's
set and never checks it against `language`, so `{language: 'es', locale:
'fr-CA'}` is a storable transcript that gets translated from French.
Columns are also keyed by base language (back end does
`language.split('-')[0]`), so `fr-CA` and `fr` collide in one column.
Both codes get blocked.
- `jsapp/js/components/processing/common/utils.tests.ts` — 10 tests over
the two new helpers: acceptance-vs-creation order, unaccepted versions,
deleted text, locale/language disagreement. Mutation-checked by breaking
each rule in turn and confirming the matching test went red.
- `jsapp/js/com... (continued)

9568 of 12890 branches covered (74.23%)

30985 of 37771 relevant lines covered (82.03%)

5.51 hits per line