kobotoolbox / kpi / 31162029831

82%

master: 76%

push

github

feat(dataTable): freeze and hide for all DEV-2035 (#7343)

### 📣 Summary

Users without editing permissions can now hide, show, and freeze columns
in Project → Data → Table for their own session, without changing what
anyone else sees.

### 💭 Notes

Previously the "Hide field" and "Freeze field" options, along with the
whole "Hide fields" dropdown, were only shown to users who could edit
the project. That's because picking one of them saves the choice into
the project settings for everybody.

Now everyone gets these options. Users who can edit the project keep
saving their choice for all project users, exactly as before. Everyone
else gets the same options applied only to their own browser session —
nothing is saved, and reloading the page brings the original layout
back. The message at the top of the "Hide fields" dropdown now says
which of the two is happening.

Changes here:

- **`tableStore.ts`** — `saveTableSettings()` already picked between
saving to the asset and falling back to session-local `overrides`. But
`getTableSettings()` and `setOverrides()` only knew four settings, and
`selected-columns` / `frozen-column` weren't among them, so un-hiding
the buttons alone would have made them no-op.
  - both methods now loop over one shared `OVERRIDABLE_SETTINGS` list
- `applySetting()` keeps the `undefined` check, not a falsiness one —
`null` means "show everything" for `selected-columns` and "nothing
frozen" for `frozen-column`, so unfreezing needs it
  - it deep-clones, since `table.tsx` mutates these arrays in place
- **`tableColumnSortDropdown.tsx`** — dropped the `change_asset`
wrapper. The `asset` prop existed only for that check, so it went too.
- **`table.tsx`**
- `ColumnsHideDropdown` is no longer gated — it's the only way back once
you've hidden a column, since the header you'd click to unhide it goes
with it
- the overrides check now compares the whole overrides object via
`isEqual` instead of `JSON.stringify` on one key. A store trigger i... (continued)

9580 of 12890 branches covered (74.32%)

31016 of 37771 relevant lines covered (82.12%)

5.51 hits per line