thorstenalpers / Finance.NET / 31160168839

91%

push

github

Give the retry back-off its own setting instead of reusing HttpTimeout (#58)

HttpTimeout was passed to PollyPolicyFactory as the back-off base as well as
being applied as client.Timeout, so raising the HTTP timeout silently
multiplied total retry latency. With the shipped defaults (HttpTimeout 20,
HttpRetryCount 10) the linear 20s x n back-off summed to 1100s - over 18
minutes of sleeping for a single failing call.

- Add FinanceNetConfiguration.HttpRetrySleepTime (default 1s) and pass that,
  not HttpTimeout, to the policy factory. HttpTimeout keeps its documented
  meaning as the HTTP client timeout only.
- Replace the linear back-off with exponential growth from the base (1s, 2s,
  4s, ...), capped at 30s per attempt, plus up to one base interval of jitter
  so concurrent callers do not retry in lockstep. Same defaults now total
  ~181s instead of 1100s, and a base of 0 retries without waiting.

Adds RetryBackOffTests covering the default, the growth curve, the cap, the
jitter, and - the regression that matters - that a generous HttpTimeout no
longer drives the back-off.

479 of 613 branches covered (78.14%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

1750 of 1818 relevant lines covered (96.26%)

92.19 hits per line