thorstenalpers / Finance.NET / 31160093163

91%

push

github

Honour CancellationToken through the retry policy (#55)

Every public API accepted a CancellationToken, but the token never reached
Polly: all call sites used the ExecuteAsync(Func<Task<T>>) overload, which
takes no token. The token did reach HttpClient.SendAsync, so an in-flight
request was cancellable, but the back-off sleeps between retries were not --
and with the default configuration a call spends nearly all of its time
asleep there. A cancelled call kept running for the full retry budget.

- Switch all 15 _retryPolicy.ExecuteAsync sites across the four services and
  YahooSessionManager to the token-aware overload, and use the token Polly
  hands the delegate.
- Stop swallowing cancellation in the surrounding error handling: each
  catch-all that wrapped everything in FinanceNetException now rethrows
  OperationCanceledException when the caller's token was cancelled. Without
  this the fix above would still surface as FinanceNetException. Cancellation
  is only rethrown when the caller cancelled, so an HttpClient timeout is
  still wrapped as before.
- YahooFinanceService.GetInstrumentsAsync and FetchSymbolsAsync no longer
  degrade cancellation into a logged warning / partial result.

Adds CancellationTokenPropagationTests, which cancels each entry point shortly
after it starts and asserts it gives up long before the back-off would elapse.
Against the old code all six tests fail with FinanceNetException after sleeping
out the full budget.

477 of 611 branches covered (78.07%)

Branch coverage included in aggregate %.

68 of 86 new or added lines in 5 files covered. (79.07%)

1742 of 1810 relevant lines covered (96.24%)

92.39 hits per line