umputun / agterm / 31082125472
98%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 90
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.881%. Remained the same
31082125472

push

github

web-flow 
fix: keep the injected environment on surfaces created by a dark launch (#378)

* fix: keep the injected environment on surfaces created by a dark launch

libghostty rebuilds a surface's config when the app's conditional state differs
from the config's, and that rebuild replays the config files alone — it keeps
working-directory and drops the per-surface env_vars, initial_input and command.
A host-built config always resolves light, so a dark launch with a conditional
theme = light:,dark: spawned every restored surface with no AGTERM_*, no restore
replay and no session.new --command.

Re-side the app config in applicationDidFinishLaunching, before any scene mounts:
GhosttyApp is built before NSApp exists, so its own appearance read is always
light, and the KVO appearance reload is debounced until after the launch restore.

Fix #260

* test: pin the dark-launch precondition and poll the probe's contents

The #260 test set the forced appearance and never observed it, so it passed on a
light launch too — where no surface rebuild happens and the assertions hold
regardless. Poll the bare debug.appearance side before probing.

writeEnvProbe polled for the file's existence while every assertion reads its
contents: `> file` truncates before printf writes, and a retry saw the previous
attempt's file. Poll the content and drop the file each attempt, matching
pollMarker and the other sibling probes.

Also correct the comment above `_ = GhosttyApp.shared`: libghostty is booted
from SettingsModel.init during App.init, not there.

7392 of 7552 relevant lines covered (97.88%)

4549988.42 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31082125472.1 90
97.88
 GitHub Action Run
Source Files on build 31082125472