umputun / agterm / 31084139353
98%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 90
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.881%. Remained the same
31084139353

push

github

web-flow 
fix the Toolbar Hidden hairline at the window top edge (#379)

* revert: drop the fullscreen titlebar-blend fallback

e962e84 redirected the titlebar lookup into the NSToolbarFullScreenWindow child
window to suppress a hairline it attributed to NSTitlebarBackgroundView. The
hairline is drawn by the app itself, so the fallback could never remove it.

The lookup also races the child window's creation: it does not exist yet when
sync runs one main-queue hop after didEnterFullScreen, and nothing re-applies
afterwards. When it wins the race it hides the reveal strip's background and the
traffic lights draw over the first sidebar row with no strip behind them.

Related to #368

* fix(window): drop the titlebar hairline in hidden toolbar mode

Both columns draw a 1px chromeText separator between the custom titlebar row and
the content below it. Hidden mode sets titlebarHeight to 0, so the line sits on
the window's top edge with no row above it, separating nothing.

Most visible in native fullscreen on a notched display, where the window sits
below the notch and the line reads as an artifact between the black band and the
terminal. Verified by eye in an isolated fullscreen instance; SwiftUI views do
not render in hosted tests.

Fix #368

* fix(dashboard): drop its own titlebar hairline in hidden toolbar mode

The dashboard draws its own 1px chromeText line to restore what its opaque
backdrop covers, so suppressing the one in WindowContentView left this copy
painting the same artifact. windowOverlayLayer is inset by titlebarHeight, 0 in
hidden mode, so opening the dashboard put the line back on the window's top edge.

Related to #368

* fix(dashboard): paint an opaque backing under the caption pill

The idle fill falls back to chromeText at 22% when the theme sets no
selection-background, and the pill overhangs the cell's frame line, so the
highlight ring read through the capsule and crossed the session name. Layering
after the ring never fixed that on its own... (continued)

7392 of 7552 relevant lines covered (97.88%)

4549988.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31084139353.1 90
97.88
 GitHub Action Run
Source Files on build 31084139353