umputun / agterm / 31075733421

98%

Build Type

push

github

Committed by umputun

Commit Message

fix(restore): make a captured foreground command replay exactly once

Closing the last window captured each pane's running command, but nothing
consumed that capture durably. The surface factory cleared it in memory and
restore(from:) never wrote back, so the argv sat in windows/<id>.json until an
unrelated structural save — for a window the user only types into, possibly
never. A crash or force-quit in that interval re-ran the command on the next
launch: an `ssh prod` or `npm run dev` the user saw restore once started a
second time unasked.

loadStore now strips the captures as the launch arms them, and the arming moved
to transient pendingForegroundCommand/pendingSplitForegroundCommand slots that
snapshot() does not serialize. Both halves are needed: the strip alone left the
persisted fields live until each surface spawned, and any save in that gap wrote
the argv straight back — applyInactiveWindowSidebarHiding does, and so does the
debounced save reselectIfSelectionHidden schedules from inside restore(from:).
A failed strip disarms instead, since losing a restore to a disk error beats
repeating a command.

Every site that cancels an armed replay moves with it or silently stops working:
recoverOrphanedWindows and restore.clear cleared the persisted fields, now
always nil there, and clearPendingRestoreOverrides has to drop the capture
payloads so one armed at bootstrap does not survive a soft-close round trip.
The split slot is seeded only for a shown split, matching pendingSplitRestoreCommand
and the capture side, so a hidden split's argv can no longer fire on a later ⌘D.

Snapshot conversion moves to AppStore+Snapshot.swift; AppStore.swift was at 999
of its 1000-line budget. restore(from:) stays behind, touching two properties
private to that file.

Coverage Stats

121 of 122 new or added lines in 3 files covered. (99.18%)

1 existing line in 1 file now uncovered.

7392 of 7552 relevant lines covered (97.88%)

4549988.25 hits per line