umputun / agterm / 31072326264

98%

push

github

fix: capture running commands before window-close surface teardown (#370)

* fix(restore): capture running commands before window-close surface teardown

Closing the last window tears every surface down before applicationWillTerminate
runs, so the quit-time capture found no surfaces and saved null over every running
command. Capture the closing window's sessions in willClose while their surfaces
are still alive; skipped during app termination, where the quit-time capture has
already run and a re-read could overwrite a good value with nil for a foreground
that exited in the meantime. Also covers closing a non-last window, whose commands
were previously never captured at all. Covered by a UI test exercising the
close-the-last-window exit.

* fix(restore): gate captured foreground commands on launch restore

The willClose capture fires on any window close, so session(from:) copying
foregroundCommand/splitForegroundCommand unconditionally let a mid-process
reopen (window.select / Open Window, Reopen Closed Item) replay a live
command with no quit — against the documented clean-quit-only replay. Copy
both fields only under launchRestore, next to the existing override gate;
the close-the-last-window exit still restores, since a launch bootstrap is
exactly where the gate opens.

Unit tests pin the gate both ways; the snapshot round-trip test now goes
through launchRestore (the real quit-to-launch cycle) instead of pinning
the ungated copy. New UI test closes a tee-running window while a second
stays open, reopens it in the same run, and asserts the marker is not
recreated — verified red without the gate, green with it.

* docs(rules): sync restore-capture note with the willClose capture and launch-only replay gate

* fix(restore): scrub stale on-disk captures outside the clean launch cycle

The willClose capture leaves a window's captured argv in windows/<id>.json
after any close, and two consumers could still replay it against the
launch-only contract: a mi... (continued)

37 of 37 new or added lines in 2 files covered. (100.0%)

7335 of 7497 relevant lines covered (97.84%)

4583367.94 hits per line