jandelgado / jled / 31008910440

97%

push

github

perf: Narrow eval time to period t (#188)

* narrow effect Eval(t) to a 16-bit period_t

TJLed::Update() always calls Eval(t_cycle) with t_cycle < period, and
Period() already returns uint16_t, so t structurally never needs more than
16 bits. Carrying it as uint32_t everywhere costs extra register/stack
traffic on MCUs without a hardware divider/wide ALU (AVR) and promotes
otherwise-16-bit compares, adds, subtracts and divides to 32-bit ops,
including in user-written Eval() overrides.

* update examples for BrightnessEvaluator::Eval's period_t signature

Follows the breaking change to BrightnessEvaluator<Brightness>::Eval's
parameter type (uint32_t -> period_t). morse_effect.h also needed pos
retyped explicitly to jled::period_t: t/speed_ used to promote to uint32_t
(unsigned) and now promotes to plain int (signed) since both operands are
16-bit, which triggered a signed/unsigned comparison warning against
morse_.size().

* update morse example for BrightnessEvaluator::Eval's period_t signature

* document BrightnessEvaluator::Eval's period_t signature

187 of 202 branches covered (92.57%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 3 files covered. (100.0%)

619 of 631 relevant lines covered (98.1%)

751.73 hits per line