coreui / coreui-pro / 30958941902

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(popup): fade the panel in, the way Menu already animates (#698)

* feat(popup): fade the panel in, the way Menu already animates

Menu was the only thing in the library using @starting-style, inherited
with the port. The .popup primitive - six components' panels - appeared
instantly, so a picker snapped open next to a menu that glided.

It fades now, through the same three-part recipe: allow-discrete makes
display animatable, @starting-style supplies the state to animate from
(the element does not exist to be styled before it is shown), and
opacity carries the motion.

No scale, deliberately. A popup carries no placement attribute, so a
scale would need an origin we cannot know - and on a panel the size of a
calendar even 2% reads as the panel jumping rather than appearing. The
combobox list hid that; the pickers did not.

Verified by sampling computed style through the transition rather than by
reading the CSS: opacity 0 at the first frame, 0.91 at ~60ms, 1 when
settled. The visual suite cannot see this - it freezes transitions on
purpose - but a fading panel is composited, and a composited layer
rasterises text differently enough between frames to trip a comparator
counting antialiased pixels. The three popup screenshots get a larger
allowance for that, and only for that; the icon-colour changes this suite
exists to catch move far more pixels.

* fix(Combobox): mark the panel itself as shown, not only its root

The fade I just added made a latent split visible: Combobox added .show to
the popup only when the panel was teleported, and otherwise relied on
`.autocomplete.show &` to set display. That worked while display was the
only thing keyed on the class. Once opacity was keyed on it too, the
untelevised path left the panel laid out and fully transparent —
autocomplete and multi-select opened into nothing.

The panel carries its own open state now, teleported or not, and the
parallel display rules in the combobox and picker partials are gone. T... (continued)

Coverage Stats

4266 of 4819 branches covered (88.52%)

Branch coverage included in aggregate %.

2 of 0 new or added lines in 0 files covered. (NaN%)

3 existing lines in 1 file now uncovered.

8272 of 8667 relevant lines covered (95.44%)

362.76 hits per line