coreui / coreui-pro / 30944146876

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(PasswordInput)!: build the frame and the toggle, like Number Input (#695)

* feat(PasswordInput)!: build the frame and the toggle, like Number Input

The component already owned the icon; it owns the button and the frame that
lays it out now, so the markup is a plain form control:

  <input type="password" class="form-control" data-coreui-toggle="password-input">

data-coreui-toggle moves from the button to the input - there is no button
in the markup to put it on - and its value becomes the component's name, so
it reads the same as Number Input's.

The wrapping is one helper shared by both components rather than a copy in
each: ensureControlGroup / releaseControlGroup in util/form-control-group.
It carries the rule Number Input arrived at, that every class except
.form-control moves to the frame, because a class on the control describes
the field and the field is the frame once it is wrapped.

The accessible name of the toggle is an option now (ariaToggleLabel), since
the button is no longer the author's to label.

* test(visual): commit the Linux baselines so CI actually compares

The Visual job has been passing on every pull request by generating
baselines rather than checking against them: with no *-chromium-linux.png
in the tree, the matcher creates the set and the run ends green. Visual
regressions were only ever caught on a maintainer's machine.

These are the 33 the job generated on this branch, so they carry the
markup this pull request settles. The next run compares.

* docs(NumberInput): correct an overstated verification claim

The comment said the spinner rules were verified in all three engines.
Two were measured; Playwright's WebKit would not launch here, which the
pull request body said and the comment did not. It now states what was
measured and what each rule leaves behind when used alone.

* docs(NumberInput): record that Safari was checked by hand

Coverage Stats

4268 of 4821 branches covered (88.53%)

Branch coverage included in aggregate %.

49 of 0 new or added lines in 0 files covered. (NaN%)

2 existing lines in 2 files now uncovered.

8272 of 8668 relevant lines covered (95.43%)

362.5 hits per line