dangernoodle-io / breadboard / 30958745443

97%

push

github

fix: raise bb_data's binding-table cap to cover smoke's real 9-key composition (#1228)

examples/smoke's board-invariant bb_wire.h manifest declares 8 distinct
binds_data= keys (reboot, factory_reset, storage_delete, wifi, fan, power,
thermal, log), but bb_diag_routes_init() also self-binds a 9th,
undeclared key (diag.boot) as a side effect of route registration -- both
codegen's check_binds_data_cap and the binds-data-mismatch lint are blind
to it (the real bb_data_bind() call lives in a different component,
components/bb_diag, reached only through a wrapper). PR #1227's smoke
'log' bind was the one that tipped BB_DATA_MAX_BINDINGS=8 into
BB_ERR_NO_SPACE on bench hardware.

Raise the cap (still a plain compile-time literal -- the codegen gate
parses it via raw-text grep, not the preprocessor, so it can't be
Kconfig-bridged) to 12, covering the real 9-key need with headroom.
bb_data_bind() now also logs the rejected key at error level on
exhaustion, since the generic composition-root log line names no key.

8370 of 8930 branches covered (93.73%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

14085 of 14240 relevant lines covered (98.91%)

2603.66 hits per line