dangernoodle-io / breadboard / 30954213142

97%

push

github

feat: link and data-exercise bb_data_http's espidf backend in smoke (B1-1425) (#1227)

smoke never called bb_data_http_espidf_start/routes_init/ws_routes_init,
so ESP-IDF's --gc-sections dropped the entire ESP-IDF backend (including
espidf_send_fn/ws_connect_cb/ws_disconnect_cb) from firmware.elf on every
CI board despite the TU compiling cleanly -- three recent PRs modified
that backend citing a green smoke build that only proved compilation, not
linkage. feat: not test:, because this composes two genuinely live HTTP
endpoints (GET /api/events, GET /ws/events) carrying real "log" traffic
into smoke's runtime firmware image, not scaffolding that only runs under
a test harness.

Adds manifest entries to examples/smoke/main/bb_wire.h expressing the real
prerequisite chain -- bb_data_http_init() (review fix: the first pass
linked routes_init()/ws_routes_init() without ever calling init(), so both
endpoints rejected every client with BB_ERR_INVALID_STATE) then
bb_data_bind("log", ...) then bb_data_http_espidf_start() then
bb_data_http_attach_sized("log", ...) then the two routes_init calls --
via requires=/provides= tokens instead of relying on textual order (a
second review pass dropped the over-constrained data_log_bound requires=
from _espidf_start, since bb_data_http_client_acquire_ex() only gates on
bb_data_http_init(), not on any bound key), plus binds+attaches the "log"
bb_data key (same shape as examples/floor/main/floor_app.c's own
producers[] loop) so both endpoints carry real traffic instead of
accepting connections that stream nothing. Also documents
bb_data_http_init() as a prerequisite on all three bb_data_http_espidf_*
entry points (components/bb_data_http/include/bb_data_http.h), the doc
gap that let the omission through review.

Bundled fix, same PR (pre-existing bug this PR's linkage exposed, the
enabling fix without which this PR cannot build): platform/espidf/
bb_ws_server/bb_ws_server.c's CONFIG_HTTPD_WS_SUPPORT=n stub block was
missi... (continued)

8370 of 8930 branches covered (93.73%)

Branch coverage included in aggregate %.

14083 of 14238 relevant lines covered (98.91%)

2612.86 hits per line