dangernoodle-io / breadboard / 30964904904

97%

push

github

fix: account for hidden and hand-wired bb_data_bind() calls in the binding cap (#1229)

- add wire_parse.INDIRECT_BB_DATA_BINDS, an explicit manifest of known
  bb_data_bind() calls check_binds_data_cap cannot otherwise see: a
  cross-component wrapper call (trigger_fn, e.g. diag.boot via
  bb_diag_boot_bind()/bb_ota_check_config_bind()) and a hand-wired,
  board-conditional entry-point call (trigger_component, e.g.
  health.display via bb_display_info_bind(), reached only through
  app_main(), never a marker) -- the shape that caused a real outage where
  the cap check reported declared keys 'fits' while the runtime table
  took an extra, undeclared bind
- check_binds_data_cap folds each manifest entry's key into its
  distinct-key count whenever its trigger is present -- trigger_fn in the
  resolved marker composition, or trigger_component in the caller-supplied
  per-board resolved component set -- so it counts the real number of
  bindings a composition makes, not just the declared ones
- also extracts the key straight out of a marker whose fn= is the real
  bb_data_bind() library function itself (called via args=, e.g. smoke's
  'log' key) -- a third accounting shape neither binds_data= nor the
  indirect-bind manifest can express; guards against adjacent
  string-literal concatenation silently truncating that key
- add the binds-data-hidden-bind lint rule as the manifest's completeness
  gate: it scans every component's own tree plus every example's
  hand-wired entry point for real bb_data_bind() call sites, builds a
  coarse call graph seeded from both marker fn= bodies and known
  entry-point functions (app_main/main), and hard-fails on any call
  reachable from a real composition root whose key is neither
  component-wide declared nor covered by the manifest -- proven to catch
  both the diag.boot and the display-board regressions when their
  manifest entries are removed; also hard-fails on an examples/*/main/
  directory whose entry point ... (continued)

8370 of 8930 branches covered (93.73%)

Branch coverage included in aggregate %.

14085 of 14240 relevant lines covered (98.91%)

2612.36 hits per line