ZelAnton / ProcessKit-rs / 30956789552

94%

Build Type

push

github

Committed by ZelAnton

Commit Message

Stop the merge-pipe reader from parking a blocking-pool thread on Unix

The Unix side of Command::merge_stderr_in_pipe read its shared stdout+stderr
pipe through tokio::fs::File, so each read occupied a runtime blocking-pool
thread. Dropping the reading future only cancels the wait, not the
underlying read(2); a grandchild that inherited the pipe's write end could
hold that thread — and the pipe's read end — parked for as long as it lived,
even after the direct child exited and the chain was torn down.

Move that reader onto the reactor with O_NONBLOCK + AsyncFd, mirroring the
existing PTY master fd pattern: a read with nothing available holds no
thread, and dropping the reader closes the fd immediately. Windows is
unaffected and keeps its tokio::fs::File-backed reader for now. Add
integration regressions through launch/pump_lines_core covering the normal
merged-output path, EOF, read-error propagation, and teardown against a
grandchild that keeps the write end open without producing output.

Coverage Stats

132 of 137 new or added lines in 2 files covered. (96.35%)

276 existing lines in 5 files now uncovered.

27486 of 28908 relevant lines covered (95.08%)

21284.71 hits per line