ZelAnton / ProcessKit-rs / 30995825362

94%

Build Type

push

github

Committed by ZelAnton

Commit Message

Don't let a refused leaf rmdir erase a live child from the registry

LeafSlot::drop released the leaf's registry entry regardless of whether
remove_dir actually succeeded, on the premise that a spawn returning Err
never leaves a live child behind. tokio's own post-fork setup can fail
after the std child already exists, dropping it without a kill - the child
is already in its leaf by then, so a refused (non-empty) rmdir meant a live
member the registry had already forgotten. members_with reads only the
registry, so kill_all could report success without touching it. Register
the leaf pid-less instead of dropping it on a refused or otherwise-failed
remove_dir, matching the release-only-on-a-kernel-confirmed-answer rule
Leaves::reclaim already follows.

Coverage Stats

374 of 633 new or added lines in 2 files covered. (59.08%)

10 existing lines in 3 files now uncovered.

27834 of 29496 relevant lines covered (94.37%)

20859.39 hits per line