dangernoodle-io / breadboard / 30948123709

97%

push

github

feat: wire bb_data_http egress to bb_ws_server WS transport (B1-1050 PR-1) (#1226)

- add a WS fd->(server,client) side table in the espidf backend, mirroring
  the existing SSE side table's spinlock discipline
- espidf_send_fn's WS branch calls bb_ws_server_broadcast_frame_async
  instead of rejecting is_ws clients with BB_ERR_UNSUPPORTED; the return
  value is the enqueue result only (B1-1424: real delivery outcome arrives
  later via httpd's async worker and is not plumbed back -- and note the
  drain loop does not consult this return at all today, for SSE or WS)
- hook bb_ws_server_set_connect_cb/set_disconnect_cb to
  bb_data_http_client_acquire_ex(is_ws=true)/_release, parallel to the SSE
  connect path
- add bb_data_http_espidf_ws_routes_init() registering GET /ws/events via
  bb_ws_server_register_endpoint, with inbound frames explicitly discarded
  (WS ingress is a separate tracked design, epic B1-828)
- topic filtering is not available on this path yet (B1-1423): bb_ws_server's
  connect callback carries no request handle to parse a query param from
- add a bb_data_http_client_is_ws_for_test() host accessor plus tests
  pinning is_ws threading through client_acquire_ex/_ex

Not yet linked into any example: bb_data_http_espidf_ws_routes_init() has
no caller anywhere in the tree, so this whole TU (both the new WS code and
the pre-existing SSE half) is linker-GC'd out of examples/smoke's build
today (verified via nm against the built ELF -- zero bb_data_http_espidf.c
symbols present, before or after this change). espidf_send_fn's is_ws
branch can therefore never execute at runtime yet either, since nothing
calls ws_connect_cb to ever set client->is_ws=true. Wiring a WS-enabled
example (and therefore actually linking and exercising this code) is a
later, HW-gated PR. This PR is compile-verified only (esp32 smoke build,
which does have CONFIG_HTTPD_WS_SUPPORT=y, so the WS branches at least
type-check and compile) -- it is NOT runtime-validated, N... (continued)

8370 of 8930 branches covered (93.73%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

14083 of 14238 relevant lines covered (98.91%)

2611.04 hits per line