dangernoodle-io / breadboard / 30930463101

97%

push

github

feat: thread key through the bb_data_http egress send_fn seam (B1-1123 PR-2) (#1225)

Add a key parameter to bb_data_http_send_fn (client identity alone
answered who to write to; key answers what is being written -- a
future MQTT consumer needs it to pick a topic). Fixes the id collision
noted in PR-1: the drop-marker frame's outbound push previously reused
literal id 0, colliding with the real attach-table index 0. It now
pushes under a dedicated BB_DATA_HTTP_DROP_MARKER_ID sentinel
(UINT32_MAX), resolved to the reserved key literal "dropped" before
falling through to the normal attach-table lookup, so the hot
real-frame path only pays one sentinel comparison. SSE framing
(espidf_send_fn) is untouched -- key is accepted and ignored, no
event: line added (tracked separately).

Host capture stub uses bb_strlcpy (the repo's canonical helper,
already used in the sibling common.c this same commit touches)
instead of hand-rolled strncpy+NUL-termination, and factors the
shared idx-bounds-check into one frame_at() helper reused by both
accessors.

8368 of 8928 branches covered (93.73%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

14081 of 14236 relevant lines covered (98.91%)

2602.01 hits per line