stacklok / toolhive / 30944486877

70%

Build Type

push

github

Committed by web-flow

Commit Message

Expire the refuted-Modern-hint memory after a TTL (#6185)

The modernHintRefuted flag (added for #6154) stops legacyInit re-probing
server/discover on every call for a backend whose Legacy-handshake version
hint was contradicted by an authoritative discover probe. It was never
evicted: a backend that lied once (hint Modern, discover Legacy — e.g.
github-mcp-server v1.6.0) and was later redeployed genuinely Modern stayed
pinned Legacy forever, because the flag suppresses the confirming probe
that would flip the cache.

Store the refuted-at timestamp and expire entries after a TTL (default
5m, overridable via WithRefutationTTL for tests). A persistent liar now
pays one confirming probe per window instead of per call; a redeemed
backend self-heals its cached (and CRD-status-reported) revision within
one window. The #6154 anti-oscillation behavior is unchanged within the
window — the existing hint-liar test still passes unmodified.

Closes #5992

Coverage Stats

19 of 19 new or added lines in 1 file covered. (100.0%)

10 existing lines in 4 files now uncovered.

82943 of 118675 relevant lines covered (69.89%)

98.72 hits per line