stacklok / toolhive / 30930694184
70%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 870
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.879% (-0.06%) from 69.941%
30930694184

push

github

web-flow 
Pin elicitation fail-fast without a standalone stream (#6182)

* Pin elicitation fail-fast without a standalone stream

A downstream client that advertised the elicitation capability but holds no
open standalone SSE stream passes go-sdk's capability gate, yet the
elicitation cannot be delivered: under the shim's JSONResponse transport the
go-sdk routes server->client requests to the standalone stream, and a
missing stream rejects the write ("rejected by transport: stream not
connected or already closed"). The mid-call tools/call fails fast with a
tool error rather than hanging to the deadline.

TestForwarding_Elicitation_AdvertisedButNoStream_FastFails pins that
behavior end to end through vMCP (the timing assertion is on the call
itself, which returns in single-digit ms; the suite's 30s teardown cost is
a pre-existing idle-connection artifact of the forwarding fixtures, not the
path under test). The no-listen downstream-client variant force-closes idle
connections at teardown so its own cleanup does not add to that cost.

Also documents the two delivery constraints in the vMCP architecture doc:
the advertised-but-no-stream fail-fast, and cross-pod origination requiring
session affinity (a server->client request can only be delivered by the
replica holding the client's standalone stream; the durable fix is the
2026-07-28 revision's MRTR, which has no stream-locality requirement).

Part of #5975

* Address amirejaz's review on cleanup ordering and test conventions

- Cleanup ordering: register CloseIdleConnections BEFORE c.Close() so LIFO
  teardown runs it after the session-terminating DELETE (which opens a
  fresh connection over hc that would otherwise linger). Comment corrected
  to note the suite's ~30s httptest.Server.Close stall is the vMCP-side
  backend-client connection, which this helper does not own — verified by
  the identical stall on the pre-existing RealBackend tests.
- Derive the fail-fast bound from forwardingRealBackendTimeout/4 ins... (continued)

82917 of 118658 relevant lines covered (69.88%)

98.59 hits per line

Coverage Regressions

Lines Coverage ∆ File
66
61.48
 -5.67% pkg/workloads/manager.go
6
20.11
 -3.45% pkg/client/manager.go
5
0.0
 -100.0% pkg/workloads/sysproc_unix.go
3
73.79
 -2.91% pkg/state/local.go
2
82.06
 -0.21% pkg/vmcp/composer/workflow_engine.go
Jobs
ID Job ID Ran Files Coverage
1 30930694184.1 870
69.88
 GitHub Action Run
Source Files on build 30930694184