stacklok / toolhive / 30946223642

70%

Build Type

push

github

Committed by web-flow

Commit Message

Forward resource-read _meta in vMCP and the transport bridge (#6180)

* Forward resource-read _meta in vMCP and the transport bridge

Backend _meta on a resources/read result never reached a vMCP client on
the Legacy path: coreResourceHandler/coreResourceTemplateHandler returned
bare []mcp.ResourceContents and dropped result.Meta, as did the stdio
transport bridge. The Modern path preserved it (its hand-rolled envelope
bypasses the SDK handler), leaving a client-visible fork between revisions
for the same backend and request.

Consume the result-returning resource handler added in toolhive-core#211
(mcpcompat AddResourceWithResult/AddResourceTemplateWithResult and the
NewServerResourceWithResult/NewServerResourceTemplateWithResult value
constructors for the per-session registration path):

- vMCP Serve path: coreResourceHandler and coreResourceTemplateHandler now
  return server.ResourceResultHandlerFunc and route result.Meta through
  conversion.ToMCPMeta, so reserved io.modelcontextprotocol/* keys get the
  same strip every other Legacy egress gets (#5986). Registrations switch
  to the WithResult constructors.
- Stdio bridge: resource and template forwarders use
  AddResourceWithResult/AddResourceTemplateWithResult and pass the upstream
  result through intact.
- TestMetaPreservation_ReadResource now asserts preservation instead of
  documenting the stale "SDK limitation" (go-sdk always supported the
  field; the gap was mcpcompat's mcp-go-shaped handler signature).
- TestServeCoreResourceHandler gains a case asserting backend _meta is
  forwarded and reserved keys stripped.

The go.mod replace directive pins toolhive-core to the PR branch until a
release carries toolhive-core#211; it must be swapped for the release tag
before merge.

Closes #6028
Part of #6027

* Bump toolhive-core to v0.0.38

The release carries #211 (result-returning mcpcompat resource handlers),
which this branch consumes; swap the pseudo-version pin for the tag. Its
renovate m... (continued)

Coverage Stats

19 of 25 new or added lines in 2 files covered. (76.0%)

4 existing lines in 2 files now uncovered.

83005 of 118657 relevant lines covered (69.95%)

96.45 hits per line