Eyevinn / go-608 / 30903067383

85%

Build Type

push

github

Committed by tobbee

Commit Message

fix(cmd): build every unit whole under -unit-mode, cut the run instead

buildUnitFrames built a trailing partial unit as the short unit it was, and a
per-unit builder refuses a slice too small for its build — a ~23-pair caption
needs ~23 frames — so any run whose length was not a multiple of -unit-seconds
failed: -seconds 4.5 -unit-seconds 2 errored in all five mode/policy
combinations. With -i that is the common case, since the sample count is
whatever the input has.

Tile with whole units and cut the run mid-unit instead, which is what a stream
stopping mid-segment looks like. Cutting a suffix cannot orphan a flip: an EOC
that survives still has its build ahead of it, wherever the mode put it, so the
discarded frames only cost the cues that would have followed. It also fixes
cue-start preloading the wrong second, which came from naming the successor at
frame i+perUnit while a truncated unit ended at i+u.Frames.

Coverage Stats

4 of 10 new or added lines in 1 file covered. (40.0%)

71 existing lines in 3 files now uncovered.

3818 of 4471 relevant lines covered (85.39%)

0.99 hits per line