dangernoodle-io / breadboard / 30874453449

97%

push

github

refactor: replace four hand-rolled bb_data gather adapters with a shared plain-fill thunk (#1220)

Four in-tree bb_data producers (update.available, health.display, diag.boot, and floor's log key) each carried a near-identical static adapter of the shape (void)args; return typed_fill((concrete_t *)dst); purely to satisfy bb_data_gather_fn's (dst, args) shape.

Adds bb_data_gather_plain(), a single shared thunk, plus a bb_data_plain_fill_ctx_t wrapper struct carrying the producer's typed fill pointer via a binding's .ctx (avoids stashing a function pointer directly in the void* ctx field). Each binding site still casts its typed fill to the thunk's bb_err_t(*)(void*) signature and the thunk calls through that cast pointer -- well-defined per C11 6.3.2.3p8 for the conversion itself, but calling through a function pointer whose type doesn't match the pointed-to function is UB per the same clause; benign on every ABI this project targets, and a deliberate conformance-for-DRY tradeoff versus the four adapters it replaces, which were strictly conformant here. bb_data_bind() now rejects a bb_data_gather_plain binding whose ctx or ctx->fill is NULL at composition time.

Migrates all four sites onto the shared thunk and deletes their adapters. Converts test_bb_data.c's own dt_gather_meminfo fixture to the same mechanism, and adds direct + bind/render tests for the thunk itself (value-delivery and NULL-ctx/NULL-fill rejection), verified to fail when the thunk is deliberately broken.

B1-1415

8342 of 8904 branches covered (93.69%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

14065 of 14220 relevant lines covered (98.91%)

2610.58 hits per line