dangernoodle-io / breadboard / 30877199564

97%

push

github

feat: allow rows-only bb_data bindings (B1-1418) (#1221)

bb_data_bind() now accepts a dual shape: the original scalar (desc+gather)
producer, or a rows-only table producer (desc=NULL, gather=NULL, rows set) --
a pure table producer no longer needs to fabricate a throwaway scalar
desc/gather pair. Every other combination (desc without gather, gather
without desc, everything absent) is still rejected.

Guards three NULL-derefs the relaxation would otherwise expose:
- bb_data_bind() now rejects apply set on a desc-less binding (apply writes
  through slot->desc->snap_size in bb_data_commit(), which bb_data_parse()
  never gates on).
- bb_data_render() now returns BB_ERR_UNSUPPORTED for a rows-only binding
  instead of dereferencing its NULL desc/gather -- reachable via the SSE
  broadcaster's generic per-key sweep, not just a direct caller.
- bb_data_commit() now returns BB_ERR_UNSUPPORTED (mirroring
  bb_data_render()'s guard) instead of NULL-dereferencing slot->desc/
  slot->gather when a key is rebound rows-only after a successful
  bb_data_parse() but before the matching commit -- bb_data_parse() gates
  only on slot->apply, never slot->desc, so this residual survived the
  bind-time apply/desc check above.

Extends test_bb_data_rows.c with bind-shape, render, and commit coverage for
the new rows-only path, including the stale-parse-after-rebind sequence.

8360 of 8922 branches covered (93.7%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

14071 of 14226 relevant lines covered (98.91%)

2656.49 hits per line