dangernoodle-io / breadboard / 30872593091

97%

push

github

feat: parent-qualified nested-key emit for bb_serialize_console (#1219)

Sibling BB_TYPE_OBJ children sharing a child key (e.g. bb_meminfo_heap_snap_desc's per-region internal/dma/spiram/exec objects, each with a free= field) previously collided on one console line because begin_obj/end_obj were pure no-ops. Adds a bounded path stack (sized to bb_serialize's own BB_SERIALIZE_MAX_DEPTH) that begin_obj pushes and end_obj pops, joined with '.' at emit time so a nested scalar renders as e.g. internal.free=... instead of colliding flat.

Dotted (not underscore) composition, since existing leaf keys already contain underscores and a dot is unambiguous to split back apart. BB_TYPE_ARR stays out of scope (the walker never has a key to qualify array elements with; B1-1414 already owns the array/table story).

Behaviour change, not inert: this is a repo-wide change to shipped console output, not a purely additive feature. Several nesting descriptors already reach console rendering via bb_data's generic BB_FORMAT_CONSOLE dispatch -- bb_diag_boot_wire (panic, reboot_reason), bb_health_wire (network), bb_sensor_http_wire (soc, vr, asic, board), bb_wifi_http_diag (reason_histogram), plus the motivating bb_meminfo_heap_snap_desc -- and previously emitted flat, COLLIDING keys on those console lines. They now emit qualified keys instead. This is a fix (colliding keys were the bug), not a regression, but anyone parsing those console lines will see new key names.

Hardening (review LOWs, B1-1416): push-skip-on-cap and unconditional pop are symmetric today only because the walker never recurses past BB_SERIALIZE_MAX_DEPTH before a begin_obj and never early-returns between a begin_obj and its matching end_obj -- nothing enforced either invariant, so a future walker change could desync path_depth silently. Adds an assert() in bb_console_pop_path() on underflow and an assert(path_depth == 0) at the end of bb_serialize_console_render(), converting a future desync into a loud... (continued)

8330 of 8892 branches covered (93.68%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

14063 of 14218 relevant lines covered (98.91%)

2600.77 hits per line