dangernoodle-io / breadboard / 30773619786

97%

push

github

fix: name the failing entry in generated bb_app_init.c logs (#1209)

bb_app_init_rest() only ever logged a bare aggregate first-error
code, naming no component -- identifying the culprit meant reading
generated bb_app_init.c and correlating a bare integer by hand.
Every bb_err_t-returning tier entry now logs its own fn (and
component=, when a manifest marker declared one) on the failing
branch via a shared bb_log_e format string, so the compiler merges
the format literal across every entry (-fmerge-constants) and only
each entry's own fn/component name is a new per-entry string
literal. The pre-existing aggregate line is unchanged and still
useful as a summary. Flash delta on smoke-esp32: +2596 bytes
(1171573 -> 1174169, 0.22% of used flash).

Diagnosed the reported 262: it is 0x106 / ESP_ERR_NOT_SUPPORTED,
returned as BB_ERR_UNSUPPORTED. bb_wire.h unconditionally wires
bb_ws_server_register_described_endpoint, whose real ESP-IDF
implementation is gated behind CONFIG_HTTPD_WS_SUPPORT; when that
Kconfig option is off, bb_ws_server.c compiles the stub variant,
which unconditionally returns BB_ERR_UNSUPPORTED. Plain esp32's
sdkconfig.defaults.esp32 sets CONFIG_HTTPD_WS_SUPPORT=y (and its
required CONFIG_HTTPD_WS_PRE_HANDSHAKE_CB_SUPPORT=y companion);
esp32-core-claim's sdkconfig.defaults.esp32-core-claim does not, so
this call is a deterministic BB_ERR_UNSUPPORTED there. examples/floor
never wires this entry at all (and is handwired, so it never calls
bb_app_init_rest() to begin with) -- the report's aggregate message
is structurally impossible there. Not fixed here per instructions;
this is a config/composition mismatch on esp32-core-claim, not an
obvious one-line fix (whether that env intentionally omits WS
support is a design call outside this PR's scope).

Also fixes a stale comment in bb_system_routes.h: it claimed the
bbtool init marker for bb_system_routes_init moves into this header
alongside the declarations. That marker was relocated to the
con... (continued)

8228 of 8792 branches covered (93.59%)

Branch coverage included in aggregate %.

13926 of 14081 relevant lines covered (98.9%)

2614.15 hits per line