dangernoodle-io / breadboard / 30774033303

97%

push

github

refactor!: move POST /api/reboot to /api/diag/reboot (#1210)

Reboot sat at top level next to /api/health while every comparable
administrative operation already lives under /api/diag/. Move both
route-table entries onto /api/diag/reboot for namespace consistency;
the route stays owned by bb_system (reboot-reason SSOT), only the
path changes.

Breaking change, no back-compat alias or redirect: consumers are
pinned to their own breadboard commits and are never a gate on
breadboard work. Updates the hand-authored request schema, the 200
response wire descriptor, host tests naming the path (schema-literal
walk, openapi meta wiring/golden tests, route fidelity table), and
comments/doc-comments across bb_system, bb_wifi_prov, bb_data,
examples/smoke, and the in-tree bbdevice OTA client.

Documents a provisioning-gate hazard next to the route definition:
bb_http_prov_gate's wildcard allowlist entries are prefix matches, so
a consumer that allowlists /api/diag/* during provisioning now also
exposes reboot, which a bare /api/reboot path never fell under. The
allowlist match is a pure union with no deny-entry type, so today
there is no way to carve reboot back out of such a wildcard once
added; a deny/exclude mechanism is tracked separately. Audited every
bb_http_prov_allow() call site in-tree: the sole production caller
(bb_wifi_prov_gate_wire_register) only allowlists exact paths, so
this move is not a live security regression.

B1-1398

8228 of 8792 branches covered (93.59%)

Branch coverage included in aggregate %.

13926 of 14081 relevant lines covered (98.9%)

2682.06 hits per line