dangernoodle-io / breadboard / 30773211270

97%

push

github

feat: detect stale generated bb_app_init.c at build time (#1208)

bb_app_init.c is gitignored and regenerated only by explicit make
smoke-gen*/floor-gen targets, never by CMake/PlatformIO itself; make
floor has no floor-gen prerequisite at all. A leftover copy from an
earlier checkout compiles silently even after its call targets are
renamed or deleted, confirmed on hardware (B1-1371) via a stale file
calling the long-deleted bb_health_reserve_routes().

Add bbtool verify-generated: parses every call target in a generated
bb_app_init.c and hard-fails if any has no matching declaration left
anywhere under components/, platform/, or examples/. Wire it into both
examples/smoke and examples/floor main/CMakeLists.txt via a new
bb_verify_generated_or_fail() cmake helper (cmake/bb_generated.cmake),
mirroring the existing BB_AUTOWIRE_BOARD stale-fragment guard.

Block comments (opening /* through closing */, single-line, multi-line,
or opening mid-line after real code) are blanked out over the whole file
before the per-line call-target scan runs, so a call-shaped symbol
mentioned only inside a comment is never mistaken for a live call -- the
prior per-line prefix check only skipped a block comment's star-prefixed
continuation lines, not its opening line.

This catches a call to a renamed/deleted symbol -- the exact historical
incident -- but not a stale file whose call targets still all exist,
e.g. a pure ordering regression; closing that would require re-running
the full codegen pipeline on every configure, a larger restructuring
left out of scope here.

8228 of 8792 branches covered (93.59%)

Branch coverage included in aggregate %.

13926 of 14081 relevant lines covered (98.9%)

2612.01 hits per line