dangernoodle-io / breadboard / 30772311600

97%

push

github

fix: reject unsatisfiable requires=http_server at codegen time (#1207)

render_source hoists the single provides=http_server entry's
__auto_type handle-capture line out of its own tier's normal
per-entry emission loop, rendering it AFTER every other pre_http
entry rather than at wire_graph.topo_sort's actual topo-sorted
position. A same-tier requires=http_server marker therefore looked
satisfiable to topo_sort (same-tier provider-before-dependent edge,
so no MissingProviderError), but was structurally unsatisfiable in
generated code: the dependent's bb_app_avail_http_server guard was
always false at runtime, so the call was silently skipped with a
bb_log_w, never surfacing anywhere make check/test/smoke could catch.

Add a codegen-time hard error (WireError) for this case, naming the
offending marker's fn, src_file:src_line, the unsatisfiable
capability, and the tier=regular remedy. The check is data-driven
(HOISTED_TIER_PROVIDES_KEYS + _check_unsatisfiable_hoisted_requires)
rather than a one-off http_server special-case, so a future second
hoisted provider key is covered by the same mechanism. Verified
http_server is the only key render_source hoists this way today --
provides=http_wildcard_last is checked for ordering only, never
pulled out of its tier's normal emission loop.

B1-1396

8228 of 8792 branches covered (93.59%)

Branch coverage included in aggregate %.

13926 of 14081 relevant lines covered (98.9%)

2612.87 hits per line