30747871285
91%
main: 91%

Ran 02 Aug 2026 12:31PM UTC

Jobs 3

Files 131

Run time 1min

Badge

Embed ▾

Committed 02 Aug 2026 12:23PM UTC coverage: 91.278% (+0.08%) from 91.201%

Build # 30747871285

Build Type

Pull #727

github

Committed by

liran-funaro

Commit Message

[sidecar, skills] Assert notifier metrics as eventually consistent

#### Type of change

- Test update
- Documentation update

#### Description

- `TestNotifierDirect`: the metric assertions that follow a response read now use
  `test.EventuallyIntMetric`. Only the initial-state block keeps `test.RequireIntMetricValue`,
  where nothing is in flight yet.
- The timeout step is asserted as a single `require.EventuallyWithT` condition. That step ends
  with both gauges back at the values they already held, so asserting them on their own would not
  prove the timeouts were recorded; the timeout counter is the only value the step changes, and
  requiring all three at the same instant is what keeps the gauges meaningful.
- `tests` skill: state that a metric is only eventually consistent with the worker's observable
  effect, and that an eventual assertion is vacuous when the expected value is the one the metric
  already holds. Its "Pattern 2" example was the racy form of these very assertions.

#### Related issues

- resolves #690

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #727: [sidecar, skills] Assert notifier metrics as eventually consistent

Coverage Stats

10560 of 11569 relevant lines covered (91.28%)

36816.35 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	81.9	-1.9%	service/query/query.go
2	97.83	-2.17%	service/verifier/verifier_server.go
2	94.82	-0.8%	service/coordinator/coordinator.go
1	80.33	-1.64%	utils/utils.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	core-db-test - 30747871285.1	02 Aug 2026 12:31PM UTC	100	46.56	GitHub Action Run
2	unit-test - 30747871285.2	02 Aug 2026 12:33PM UTC	95	84.76	GitHub Action Run
3	db-test - 30747871285.3	02 Aug 2026 12:33PM UTC	131	79.13	GitHub Action Run

hyperledger / fabric-x-committer / 30747871285
91%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 30747871285

hyperledger / fabric-x-committer / 30747871285 91% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 30747871285

hyperledger / fabric-x-committer / 30747871285
91%
main: 91%

README BADGES
x