hyperledger / fabric-x-committer / 30746478047

91%

main: 91%

Build Type

Pull #725

github

Committed by liran-funaro

Commit Message

[coordinator] Align VC and verifier manager stream behavior

#### Type of change

- Bug fix
- Test update

#### Description

- Bind both managers to one receive-error classification, `classifyStreamRecvError`. The VC
  manager previously retried an `InvalidArgument` under the sustain policy forever; the verifier
  manager already treated it as non-retryable. Placed beside
  `ingestIncomingTxsToInternalQueue`, the other helper both managers share.
- Skip empty batches in the VC send loop instead of marshalling and sending an empty `VcBatch`.
- Do not forward an empty batch from the verifier's receive loop to the VC manager, which is
  where those empty batches came from. The VC manager already guards its own output this way.
- Record at the VC's receive goroutine what breaks if the two output writes are bound to the
  stream context rather than the manager's: the re-queue becomes reachable on every stream
  failure, the statuses of a re-queued batch are delivered twice, and
  `Service.numTxsInProgress` is decremented twice for one transaction. The existing NOTE stated
  the requirement but not its consequence, which is what makes it easy to undo.

#### Additional details (Optional)

`TestValidatorCommitterManagerX/an_empty_batch_is_not_sent_to_the_vcservice` sends a real batch
first, because the first batch of a stream goes through `splitAndSendToVC`, which already sends
nothing for an empty batch — the empty send is only reachable once that path is behind us. With
the guard removed the test observes three batches on the wire instead of two.

No behavior changed for the failed-forward re-queue itself. The status write is already attempted
first and returns early on failure, so the nodes are never forwarded for a batch whose statuses
were dropped; the reverse ordering cannot be fixed by ordering and is instead held unreachable by
the context wiring, which is what the NOTE now explains.

This touches the same receive and send loops as #724, so whichever ... (continued)

Pull Request Pull Request #725: [coordinator] Align VC and verifier manager stream behavior

Coverage Stats

20 of 21 new or added lines in 2 files covered. (95.24%)

22 existing lines in 10 files now uncovered.

10556 of 11581 relevant lines covered (91.15%)

33939.33 hits per line