valkyrjaio / valkyrja-php / 30722663447

100%

push

github

[Orm] feat!: Configure the orm component with typed config contracts (#1086)

# Description

`Valkyrja\Application\Env\Env` is deprecated. It is one non-final class
that holds
about 120 `public const` env variables for every component at once. This
pull
request gives the Orm component its own typed config contracts. It also
converts
`OrmServiceProvider` to read those contracts.

`OrmServiceProvider` no longer reads `Env`. An application that sets an
`Env::ORM_*` constant loses that setting, so this change breaks a public
contract.

The Orm component read 26 env constants, more than any other component.
This is
the last of the fourteen components that read `Env`. After this pull
request the
framework does not read `Env` anywhere, and a later pull request removes
the
whole class.

## The shape

The component config holds only the component-wide setting, and each
connection
gets its own contract, its own default class, and its own container
binding:

- `OrmConfigContract` holds `defaultManager`.
- `OrmMysqlConfigContract` holds the nine `mysql*` settings.
- `OrmPgsqlConfigContract` holds the nine `pgsql*` settings.
- `OrmSqliteConfigContract` holds the seven `sqlite*` settings.

An application that connects to MySQL never constructs the PostgreSQL or
the
SQLite settings. The container resolves a connection config only when
something
asks for that connection.

Each property carries the connection name as a prefix, so one
application config
class can implement several of these contracts at once.
`tests/Tests/Fixtures/Orm/Data/OrmConfigFixture.php` implements all
four.

The PDO option arrays now live as defaults on each connection config.
The
provider previously read a nullable env constant and then applied the
defaults
with `??=`. The config holds those defaults directly, so the provider
reads one
property.

valkyrjaio/architecture#131 records this shape as a rule.

## A type correction

The provider annotated the MySQL strict mode as `non-empty-string|nul... (continued)

73 of 0 new or added lines in 0 files covered. (NaN%)

12724 of 12724 relevant lines covered (100.0%)

24.38 hits per line