valkyrjaio / valkyrja-php / 30721199531

100%

push

github

[Sms] feat!: Configure the sms component with a typed config contract (#1011)

# Description

`Valkyrja\Application\Env\Env` is deprecated. It is one non-final class
that holds
about 120 `public const` env variables for every component at once. This
pull
request gives the Sms component its own typed config contract and its
own config
classes. It also converts `SmsServiceProvider` to read that contract.

`SmsServiceProvider` no longer reads `Env`. An application that sets an
`Env::SMS_*` constant loses that setting, so this change breaks a public
contract.

This pull request does not change `Env.php`. Each component gets its own
pull
request, and all of those pull requests are independent. A pull request
that
deleted its own constants would conflict with every sibling pull request
on that
one file. `Env` therefore stays in place and goes unread. A later pull
request
removes the whole class.

The shape follows `Cli\Interaction`:

- `SmsConfigContract` is the container binding key. The application can
implement
the contract on its own `Config` class. `publishConfig` then binds that
object.
- `SmsConfig` is the default. `publishConfig` binds a new instance when
the
  application config does not implement the contract.
- `SmsVonageConfig` is a plain data class without a contract. It is a
value that
the parent config holds, not a service that the container resolves. This
  matches `Session\Data\CookieParams`.

This is one of 14 pull requests that give each component its own config
contract.
See #1002 for the first one, which describes the pattern in full.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Change... (continued)

35 of 0 new or added lines in 0 files covered. (NaN%)

12731 of 12731 relevant lines covered (100.0%)

24.3 hits per line