valkyrjaio / valkyrja-php / 30722829087

100%

push

github

[View] feat!: Configure the view component with typed config contracts (#1047)

# Description

`Valkyrja\Application\Env\Env` is deprecated. It is one non-final class
that holds
about 120 `public const` env variables for every component at once. This
pull
request gives the View component its own typed config contracts. It also
converts
`ViewServiceProvider` to read those contracts.

`ViewServiceProvider` no longer reads `Env`. An application that sets an
`Env::VIEW_*` constant loses that setting, so this change breaks a
public
contract.

This pull request does not change `Env.php`. Each component gets its own
pull
request, and all of those pull requests are independent. A pull request
that
deleted its own constants would conflict with every sibling pull request
on that
one file. `Env` therefore stays in place and goes unread. A later pull
request
removes the whole class.

## The shape

The component config holds only the component-wide setting, and each
renderer
gets its own contract, its own default class, and its own container
binding:

- `ViewConfigContract` holds `defaultRenderer`.
- `ViewPhpConfigContract` holds `phpPath`, `phpFileExtension`, and
`phpPaths`.
- `ViewOrkaConfigContract` holds the five `orka*` settings.
- `ViewTwigConfigContract` holds `twigPaths`, `twigExtensions`, and
  `twigCompiledPath`.

An application that renders with Twig never constructs the Orka
replacements, and
an application that renders with PHP templates never constructs the Twig
compiled
path. The container resolves a renderer config only when something asks
for that
renderer.

Each property carries the renderer name as a prefix, so one application
config
class can implement several of these contracts at once.
`tests/Tests/Fixtures/View/Data/ViewConfigFixture.php` implements all
four.

`getOrkaComponents` now takes the Orka config instead of the env class,
so the
replacement lists come from the config as well.

valkyrjaio/architecture#131 records this shape as a rule... (continued)

55 of 0 new or added lines in 0 files covered. (NaN%)

12746 of 12746 relevant lines covered (100.0%)

24.4 hits per line