dangernoodle-io / breadboard / 30676019275

97%

push

github

refactor: delete dead static-stack path in bb_ota_pull (B1-1328) (#1171)

CONFIG_BB_OTA_PULL_AUTOREGISTER is not declared in any Kconfig, so the
guard '#if CONFIG_BB_OTA_STATIC_STACK && CONFIG_BB_OTA_PULL_AUTOREGISTER'
evaluated to 0 unconditionally on every board that has ever existed,
regardless of CONFIG_BB_OTA_STATIC_STACK. The static-BSS task-stack/TCB
and static worker-arg code at all four guard sites has never executed on
any board.

This deletes the dead #if branch entirely, collapsing each site to the
always-taken dynamic-allocation path, rather than dropping only the
'&& CONFIG_BB_OTA_PULL_AUTOREGISTER' term. Dropping only that term would
leave 'CONFIG_BB_OTA_STATIC_STACK' as a live gate and switch the static-
stack path on for the first time ever -- an unvalidated BSS-vs-heap
allocation change, which is not this ticket (tracked separately as
B1-1333). CONFIG_BB_OTA_STATIC_STACK now has no remaining reference in
this file; its Kconfig declaration is left in place (B1-1333 decides its
fate).

- delete static StaticTask_t/StackType_t/ota_worker_arg_t declarations
- collapse task-arg allocation to the malloc path
- collapse the claim-conflict free path to unconditional
- collapse task creation to the dynamic-backing path
- di_legacy fence baseline shrinks 20 -> 19 (autoregister_usage entry
  for this file pruned via --update-baseline, shrink-only)

Sibling of B1-1327 (bb_ota_check), same defect class.


Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8103 of 8676 branches covered (93.4%)

Branch coverage included in aggregate %.

13743 of 13898 relevant lines covered (98.88%)

2582.84 hits per line